fix: PIN validation passing with incorrect PIN #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp0707
force-pushed
the
fix/invalidPIN
branch
from
7e388f1
to
ba9ac15
Compare
5 tasks
Codecov Report
@@ Coverage Diff @@
## main #957 +/- ##
==========================================
+ Coverage 59.26% 59.28% +0.02%
==========================================
Files 176 176
Lines 4981 4981
Branches 1399 1399
==========================================
+ Hits 2952 2953 +1
+ Misses 2004 2003 -1
Partials 25 25
|
bryce-mcmath
changed the title
bryce-mcmath
requested changes
Sep 6, 2023
Signed-off-by: Jyoti Patel <jyotipatel152@gmail.com>
Signed-off-by: Jyoti Patel <jyotipatel152@gmail.com>
Signed-off-by: Jyoti Patel <jyotipatel152@gmail.com>
jp0707
force-pushed
the
fix/invalidPIN
branch
from
1dac66f
to
8e067c9
Compare
bryce-mcmath
approved these changes
Sep 6, 2023
wadeking98
pushed a commit
to wadeking98/aries-mobile-agent-react-native
that referenced
this pull request
Sep 8, 2023
…#957) Signed-off-by: Jyoti Patel <jyotipatel152@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fix PIN validation passing with incorrect PIN.
Related Issues
#912
Pull Request Checklist
Signed-off-byline (we use the DCO GitHub app to enforce this);