Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rest] DIDComm connection query parameters #267

Open
genaris opened this issue Apr 4, 2024 · 1 comment · May be fixed by openwallet-foundation/credo-ts#1819
Open

[rest] DIDComm connection query parameters #267

genaris opened this issue Apr 4, 2024 · 1 comment · May be fixed by openwallet-foundation/credo-ts#1819

Comments

@genaris
Copy link
Contributor

genaris commented Apr 4, 2024

Currently REST API is allowing to query by alias and theirLabel, but it won't work because (as of Credo 0.5.1) they are not stored as tags in ConnectionRecord.
@genaris genaris linked a pull request Apr 4, 2024 that will close this issue
Open
@TimoGlastra
Copy link
Contributor

Hmm maybe we can remove them for now? As they won't do anything it's nit really a change, or better: passing them will never work so it fixes behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: query connections by theirLabel and alias genaris/credo-ts
2 participants
@genaris @TimoGlastra