-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(rest): switched to tsyringe for dependency injection #109
Merged
TimoGlastra
merged 4 commits into
openwallet-foundation:main
from
janrtvld:feat/tsyringe
Apr 28, 2022
Merged
refactor(rest): switched to tsyringe for dependency injection #109
TimoGlastra
merged 4 commits into
openwallet-foundation:main
from
janrtvld:feat/tsyringe
Apr 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoGlastra
reviewed
Apr 5, 2022
packages/rest/src/controllers/basic-messages/BasicMessageController.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 86.23% 86.19% -0.05%
==========================================
Files 40 41 +1
Lines 632 630 -2
Branches 83 76 -7
==========================================
- Hits 545 543 -2
Misses 87 87
Continue to review full report at Codecov.
|
Signed-off-by: Jan <60812202+janrtvld@users.noreply.github.com>
Signed-off-by: Jan <60812202+janrtvld@users.noreply.github.com>
Signed-off-by: Jan <60812202+janrtvld@users.noreply.github.com>
TimoGlastra
approved these changes
Apr 12, 2022
janrtvld
added a commit
to janrtvld/aries-framework-javascript-ext
that referenced
this pull request
Aug 26, 2022
…llet-foundation#109) Signed-off-by: Jan <60812202+janrtvld@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #16