Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rest): switched to tsyringe for dependency injection #109

Merged
merged 4 commits into from
Apr 28, 2022

Conversation

janrtvld
Copy link
Contributor

@janrtvld janrtvld commented Apr 5, 2022

As discussed in #16

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Merging #109 (25de993) into main (9b0f265) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   86.23%   86.19%   -0.05%     
==========================================
  Files          40       41       +1     
  Lines         632      630       -2     
  Branches       83       76       -7     
==========================================
- Hits          545      543       -2     
  Misses         87       87              
Impacted Files Coverage Δ
...ages/rest/src/controllers/agent/AgentController.ts 100.00% <100.00%> (ø)
...ntrollers/basic-messages/BasicMessageController.ts 94.11% <100.00%> (-0.33%) ⬇️
...rc/controllers/connections/ConnectionController.ts 80.00% <100.00%> (-0.31%) ⬇️
...rc/controllers/credentials/CredentialController.ts 81.70% <100.00%> (-0.23%) ⬇️
...lers/credentials/CredentialDefinitionController.ts 84.61% <100.00%> (-0.57%) ⬇️
...st/src/controllers/credentials/SchemaController.ts 78.57% <100.00%> (-0.74%) ⬇️
...ges/rest/src/controllers/proofs/ProofController.ts 80.76% <100.00%> (-0.25%) ⬇️
packages/rest/src/server.ts 91.42% <100.00%> (+0.25%) ⬆️
packages/rest/src/utils/TsyringeAdapter.ts 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b0f265...25de993. Read the comment docs.

Signed-off-by: Jan <60812202+janrtvld@users.noreply.github.com>
Signed-off-by: Jan <60812202+janrtvld@users.noreply.github.com>
Signed-off-by: Jan <60812202+janrtvld@users.noreply.github.com>
@TimoGlastra TimoGlastra merged commit fb4c364 into openwallet-foundation:main Apr 28, 2022
janrtvld added a commit to janrtvld/aries-framework-javascript-ext that referenced this pull request Aug 26, 2022
…llet-foundation#109)

Signed-off-by: Jan <60812202+janrtvld@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants