-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with error message on parsing a previously accepted OOB invitation #1869
Comments
It seems like |
Hey @jorgefl0, are you sure the shortened invitation is still valid after it has been accepted? In e.g. Paradym we invalidate a shortened url that has been accepted, as it can't be used anymore |
Ok, if im reading the implementation correctly, the OOB is being fetched from short URL Are you saying that Paradym returns an error which in turn results in the error message? The point of this issue is that it is not clear from the error message content that the error occurs because the OOB has already been accepted. It suggests there is a syntax error with the URL and not an issue with the state of the invitation. It isnt obvious that the interpretation of the error below that the OOB is invalid because its already been accepted.
Currently, our alternate approach to determining if an OOB invitation has already been accepted is to parse the invitation, resolve the public did from the |
I agree it's not very clear. The "or be valid shortened URL" should indicate that it's not also not a valid shortened URL. Maybe we should store the URL of the invitation so you can also query in the wallet whether an URL has already been accepted. Currently it's not possible to know that if the invitation cannot be fetched anymore, as that contains the data needed to check that. So basically how the parsing logic works:
What would you expect the error message to look like? It's quite common to invalidate invitation URLs. What is your specific use case with checking if it has already been accepted? If you create a new invitation, receive that in the agent with |
Ok, maybe I'm being naive about the semantic meaning of But to your suggestion, having the invitation URL stored would allow us to query for OOB records using the URL as query parameter |
We observe that the function call
await agent.oob.parseInvitation(invitationUrl)
returns an incorrect error message in the scenario when the input OOB invitation has previously been acceptedThe error message observed is
Our Credo implementation is currently on v0.5.3
The text was updated successfully, but these errors were encountered: