Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: demo now runs under a temp HOME directory. #1440

Conversation

daidoji
Copy link
Contributor

@daidoji daidoji commented Apr 26, 2023

Adjusted demo so that the Alice and Faber wallets are written to a temp directory created at demo runtime (via setting the HOME env variable in the script) rather than using the home directory of the user running the demo.

Fix #1430

@daidoji daidoji requested a review from a team as a code owner April 26, 2023 01:54
Adjusted demo so that the Alice and Faber wallets are written to a temp directory
created at demo runtime (via setting the HOME env variable in the
script) rather than using the home directory of the user running the demo.

Fix openwallet-foundation#1430

Signed-off-by: Charles Lanahan <charles.lanahan@gmail.com>
@daidoji daidoji force-pushed the feat/tests-write-to-temp-dir-1430 branch from 19aa926 to 6a73e08 Compare April 26, 2023 01:56
@TimoGlastra
Copy link
Contributor

Hey @daidoji, thanks for the PR!

Is the reason to put the demo under a temp directory because of the issues with re-running the demo? I have a PR that should fix this: #1439.

Or do you want to keep the data separate? For Indy SDK you can change the path using the storage_config: https://github.com/hyperledger/indy-sdk/tree/main/wrappers/nodejs#createwallet--config-credentials----void (not sure if this is exposed in the interface), and for Askar you can change the baseDataPath in the file system: https://github.com/hyperledger/aries-framework-javascript/blob/main/packages/node/src/NodeFileSystem.ts#L28-L29

@daidoji
Copy link
Contributor Author

daidoji commented Apr 27, 2023

@TimoGlastra cool, yeah if your PR covers it I can just withdraw this one. The idea was just to keep whatever wallet state from the demo out of any indy wallet credentials I might have in my home directory. Using HOME was the only way I could figure out how to do that because I didn't find what you linked.

How would I check that these are available in the interface and maybe I could update the documentation for future generations. Does that #1439 PR cover changes to get the demo working again?

@TimoGlastra
Copy link
Contributor

@daidoji now that #1439 is merged, could you check if it's fully working again in the main branch? Otherwise we can add the changes to this PR to fix it

@daidoji
Copy link
Contributor Author

daidoji commented May 17, 2023

@TimoGlastra I'll close this because it isn't wiping the Indy VDR wallet anymore but the demo is broken again or something is up. I think its trying to load libindy and failing. I'll open another issue though.

@daidoji daidoji closed this May 17, 2023
@daidoji daidoji deleted the feat/tests-write-to-temp-dir-1430 branch May 17, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI demo broken, espeically when running multiple times
2 participants