Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sd-jwt-vc): Module for Issuer, Holder and verifier #1607
feat(sd-jwt-vc): Module for Issuer, Holder and verifier #1607
Changes from 21 commits
d50a28d
cba3684
f6042c0
60ffc12
92f50ad
6a1dc9a
4bf9709
4d91c07
106b9a1
12945b6
43ba3de
acf3711
6404af5
aec8e8a
24f04ba
55a96c0
b857e4c
10831cb
625f09b
d697756
7eed255
afdd0dc
270382d
8fe5b77
c5063e1
d0b3c98
c95fe6a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the convention used in other module APIs (and services in general) we'd call it
findAllCredentialRecordsByQuery
, to make more explicit about the fact that we expect multiple records to be retrieved. Actually, in most modules we make naming simpler (e.g.findAllByQuery
), but I see it's not the case here andW3cCredentialsApi
(the API this module is based on I guess).Of course if we change this here and leave
W3cCredentialsApi
as is, it would not be consistent. And if we change it inW3cCredentialsApi
as well we'll introduce a breaking change. But I just wanted to point out this to bother you 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good point! I think we can change this in a separate PR which changes both the w3c and this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am actually not sure what the best name would be here. I think
findAllByQuery
is the best as it is already scoped undersdJwt
within theagent.modules
api.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of them to
findById
,findAllByQuery
. They will be removed in the future and I think they were too verbose before.