Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix build issue in 0.5.5 #1920

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

TimoGlastra
Copy link
Contributor

Fixes the build issue introduced in 0.5.5. We'll have to do a 0.5.6 release sadly.

It does add a few nice improvements though:

  • now also includes src in package.json
  • source maps point to source files, so whenever you now click on a type / method in e.g. vscode from credo you will be shown the source TS code rather than the build js code. Making debugging a lot easier I'd say :)

Copy link

changeset-bot bot commented Jun 25, 2024

🦋 Changeset detected

Latest commit: f330da2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@credo-ts/indy-sdk-to-askar-migration Patch
@credo-ts/question-answer Patch
@credo-ts/bbs-signatures Patch
@credo-ts/react-native Patch
@credo-ts/action-menu Patch
@credo-ts/anoncreds Patch
@credo-ts/openid4vc Patch
@credo-ts/indy-vdr Patch
@credo-ts/tenants Patch
@credo-ts/askar Patch
@credo-ts/cheqd Patch
@credo-ts/core Patch
@credo-ts/drpc Patch
@credo-ts/node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Timo Glastra <timo@animo.id>
Copy link
Contributor

@berendsliedrecht berendsliedrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will this influence the bundle size? Including the src directory can have quite an impact, right?

@TimoGlastra
Copy link
Contributor Author

Yeah it has some impact on the bundle size as you include the src, but I think it's well worth it because of the goto source now actually works and that makes debugging a lot easier.

@TimoGlastra TimoGlastra merged commit 66e696d into openwallet-foundation:main Jun 25, 2024
11 checks passed
@berendsliedrecht
Copy link
Contributor

Yeah it has some impact on the bundle size as you include the src, but I think it's well worth it because of the goto source now actually works and that makes debugging a lot easier.

If it is included in the final production bundle, I am not sure I think it is worth it. Unpacked size of @credo-ts/core is already 4.7MB. Now, with the src it will be more than double so likely something around 10MB (for just core!) and if we also include atleast libaskar.so we will add another 5-7 MB... This is getting really big IMO.

@TimoGlastra
Copy link
Contributor Author

Okay -- now released 0.5.6 as there was a build issue with 0.5.5. I'll look into it again. I like it when packages publish source code, but if it's not desired it's easy to not do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants