Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: sign-off release commit and do not publish src #1922

Merged
merged 8 commits into from
Jun 25, 2024
Merged

chore: sign-off release commit and do not publish src #1922

merged 8 commits into from
Jun 25, 2024

Conversation

TimoGlastra
Copy link
Contributor

  • do not publish src
  • sign-off release commits
  • create single tag and github release
  • do not skip ci

Signed-off-by: Timo Glastra timo@animo.id

@TimoGlastra
chore: commit message with sign-off
b24d70d 
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra
chore: do not publish src directory
df41559 
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra
release tweaks
5c2b066 
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra
create single release
d05ed4e 
Signed-off-by: Timo Glastra <timo@animo.id>
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 745748c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TimoGlastra
tag name
87e7abc 
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra
update lockfile
c8a4511 
Signed-off-by: Timo Glastra <timo@animo.id>
berendsliedrecht
berendsliedrecht approved these changes Jun 25, 2024
View reviewed changes
.changeset/commit.js
@@ -0,0 +1,24 @@
const { execSync } = require('node:child_process')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AH thats annoying... Does changesets still offer enough value if we have to do things like this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure -- it seems the amount of scripts is now similar to our previous approach. It is a bit less hacky which I like. But I'll keep looking further to an alternative. Maybe NX, or back to the lerna setup.

@TimoGlastra
fix eslint issues
0612aae 
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra
test check types
745748c 
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra merged commit 0952fca into openwallet-foundation:main Jun 25, 2024
11 checks passed
@TimoGlastra TimoGlastra deleted the chore/publishing-improvements branch June 25, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berendsliedrecht berendsliedrecht berendsliedrecht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TimoGlastra @berendsliedrecht