Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x509): use correct spki algorithm and parameters #1940

Conversation

berendsliedrecht
Copy link
Contributor

@berendsliedrecht berendsliedrecht commented Jul 3, 2024

  • used ecdsa as a spki algorithm, which is incorrect.
  • Using ecPublicKey with the curve as params now.

Copy link

changeset-bot bot commented Jul 3, 2024

⚠️ No Changeset found

Latest commit: a57fb5a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Signed-off-by: Berend Sliedrecht <sliedrecht@berend.io>
@berendsliedrecht berendsliedrecht force-pushed the x509-use-correct-spki-algorithm branch from c232f12 to a57fb5a Compare July 3, 2024 13:12
@berendsliedrecht berendsliedrecht merged commit 808878d into openwallet-foundation:main Jul 4, 2024
11 checks passed
@berendsliedrecht berendsliedrecht deleted the x509-use-correct-spki-algorithm branch July 4, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants