feat: vc13 support draft #1942
feat: vc13 support draft #1942
Conversation
🦋 Changeset detectedLatest commit: a5557eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
auer-martin
force-pushed
the
openid-vci-13-draft
branch
from
641fac2
to
353440b
Compare
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
There was a problem hiding this comment.
Great stuff on the update martin, and making sure we keep supporting both draft 11 and draft 13. The typing feels a bit off though, and it would be good if you can spend some time to make sure we are aligned, as I found several things that didn't seem to align with supporting both 11 and 13
packages/openid4vc/src/openid4vc-holder/OpenId4VciHolderService.ts
Outdated
Show resolved
Hide resolved
packages/openid4vc/src/openid4vc-holder/OpenId4VciHolderService.ts
Outdated
Show resolved
Hide resolved
packages/openid4vc/src/openid4vc-issuer/OpenId4VcIssuerService.ts
Outdated
Show resolved
Hide resolved
| clientId, | ||
| credentialIssuer: metadata.issuer, | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| endpointMetadata: metadata as unknown as any, // will be v11 / v13 based on version |
There was a problem hiding this comment.
Why does it need to be unknown? I rather not use it outside of tests. We can probably do something with an if / else statement to get the correct typing witout having to cast?
There was a problem hiding this comment.
Tried it out, not sure but typing the metadata according to the version does not work quite well, and probably requires casts anyways so I would keep this
packages/openid4vc/src/openid4vc-holder/OpenId4VciHolderService.ts
Outdated
Show resolved
Hide resolved
|
Can you also add a changeset? |
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
…atibility Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
auer-martin
force-pushed
the
openid-vci-13-draft
branch
from
52ecf48
to
701a978
Compare
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
auer-martin
force-pushed
the
openid-vci-13-draft
branch
from
701a978
to
a5557eb
Compare
No description provided.