feat(node): add http and ws inbound transport #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <timo@animo.id>
|
@karimStekelenburg Once this is merged you can directly use the inbound transports |
jakubkoci
approved these changes
Jul 19, 2021
| private logger!: Logger | ||
|
|
||
| // We're using a `socketId` just for the prevention of calling the connection handler twice. | ||
| private socketIds: Record<string, unknown> = {} | ||
|
|
||
| public constructor(socketServer: WebSocket.Server) { | ||
| this.socketServer = socketServer | ||
| public constructor({ server, port }: { server: Server; port?: undefined } | { server?: undefined; port: number }) { |
There was a problem hiding this comment.
Would it work with the following types?
Suggested change
| public constructor({ server, port }: { server: Server; port?: undefined } | { server?: undefined; port: number }) { | |
| public constructor({ server, port }: { server: Server; port?: string } | { server?: Server; port: number }) { |
There was a problem hiding this comment.
I want it to be an XOR statement. So either port or server should be provided but not both. If you create the server yourself, you set the port on the server. If you don't create the server yourself, you need to pass the port.
Could probably improve, but this was the easiest way I could think of with explicit typing that you shouldn't provide both
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves http and ws inbound transports to the node package. I know there's still work to be done on the transports, but this makes it 1000x easier to set up an agent. They're in the node package, so not strictly tied to core