Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core)!: improve proof request validation #525

Merged

Conversation

TimoGlastra
Copy link
Contributor

BREAKING CHANGE: Proof request requestedAttributes and requestedPredicates are now a map instead of record. This is needed to have proper validation using class-validator.

Signed-off-by: Timo Glastra timo@animo.id

Maintainers: Before merging and squashing make sure to copy the BREAKING CHANGE entry to the commit message field, this is needed for automatic tracking of breaking changes

BREAKING CHANGE: Proof request requestedAttributes and requestedPredicates are now a map instead of record. This is needed to have proper validation using class-validator.

Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra requested a review from a team as a code owner November 7, 2021 15:06
@TimoGlastra TimoGlastra marked this pull request as draft November 7, 2021 15:07
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2021

Codecov Report

Merging #525 (2ae23b1) into main (5e9a641) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
- Coverage   86.27%   86.25%   -0.03%     
==========================================
  Files         266      266              
  Lines        5762     5775      +13     
  Branches      931      933       +2     
==========================================
+ Hits         4971     4981      +10     
- Misses        790      793       +3     
  Partials        1        1              
Impacted Files Coverage Δ
...re/src/modules/proofs/models/ProofAttributeInfo.ts 100.00% <100.00%> (ø)
...re/src/modules/proofs/models/ProofPredicateInfo.ts 100.00% <100.00%> (ø)
...ges/core/src/modules/proofs/models/ProofRequest.ts 100.00% <100.00%> (ø)
...s/core/src/modules/proofs/services/ProofService.ts 86.55% <100.00%> (ø)
packages/core/src/utils/transformers.ts 66.66% <100.00%> (-6.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9a641...2ae23b1. Read the comment docs.

@TimoGlastra TimoGlastra marked this pull request as ready for review November 7, 2021 15:18
@TimoGlastra TimoGlastra linked an issue Nov 8, 2021 that may be closed by this pull request
@TimoGlastra TimoGlastra merged commit 1b4d8d6 into openwallet-foundation:main Nov 8, 2021
@TimoGlastra TimoGlastra deleted the proof-request-validation branch March 10, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve validation for proof request
3 participants