Dev container for AMTH #252
Conversation
Signed-off-by: Sheldon Regular <sheldon.regular@gmail.com>
Signed-off-by: Sheldon Regular <sheldon.regular@gmail.com>
| // If using a local android device/emulator you will need to mount to the location of the app apk so that it can be installed. | ||
| // Change this to your absolute path to the location of the android apk you want to test with | ||
| "mounts": [ | ||
| { "source": "/Users/Shel/Projects/BC.gov/apps/bc-wallet", "target": "/bc-wallet/app", "type": "bind" }, |
There was a problem hiding this comment.
not sure about absolute paths. Any creative ways to address it? I think of a dev container something that works out of the box to make dev life easier. The need to update paths might create false changes. But, I am okay with this being a first pass.
There was a problem hiding this comment.
We could use something like ${localEnv:SOME_LOCAL_VAR} to not have absolute paths in the devcontiner.json file.
"mounts": [
{ "source": "${localEnv:APP_LOCATION}/apps/bc-wallet", "target": "/bc-wallet/app", "type": "bind" },
However, this doesn't really fix the issue of having it work out of the box. The dev will have to setup that app location and point the env var to it. To get it to work out of the box, the repo would have to be in control of the apk, which it of course isn't.
The DEV_CONTAINERS.MD talks about this mount and the need to set the source to the location of the apk.
We could write a script to pull android artifacts from the BC Wallet repo, and place it in a predefined location on local, but that assumes the dev always wants to use the latest app build in the repo, and that wouldn't be the case, since they may have a local build based on some uncommitted work in a PR.
This should be a one time setting, and from then on out, the dev needs to just put new apk builds in that location.
This PR adds Dev Container support to Aries Mobile Test Harness/Mobile Wallet Test Harness. This will allow test developers to develop and debug wallet tests without having to standup a test dev environment locally.
See DEV_CONTAINERS.MD for usage.
Closes #230