-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submission of wallet-framework-dotnet project proposal #16
Submission of wallet-framework-dotnet project proposal #16
Conversation
Signed-off-by: Sebastian Bickerle <sebastian.bickerle@neosfer.com>
Signed-off-by: Sebastian Bickerle <sebastian.bickerle@neosfer.com>
d46a7aa
to
fa6af40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the submission. I am not sure that we will have to get to this review at the meeting on the 20th, but we will see how quickly we make it through the VC-API proposal to see if we have some time for discussion.
|
||
Currently, the framework supports DidComm v1 and AnonCreds. There is an active intention to extend support for other promising protocols, notably DidComm v2, to ensure the framework remains at the forefront of digital identity solutions. | ||
|
||
Furthermore, the team is considering the development of SD-JWT credentials as a standalone library. This might transition into a separate project proposal in the future, underscoring the commitment to modular and reusable components in the digital identity space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that we have two SD-JWT projects in the OpenWallet Foundation. One is in Python and the other in Kotlin. I am not sure if either of those projects would satisfy your need for a standalone library. It would be good to work closely together with these two projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am aware of both projects and I am also in regular contact with both authors. We prefer to have a native library/implementation, but I will make sure that this is aligned with the other implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also support having native SD-JWT implementation in different technologies. It's good however to see an alignment between all these projects: For example, share the same test scenarios and exercise their code base over them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider extracting the SD-JWT part into its own building block (library) and repository?
Furthermore, the team is considering the development of SD-JWT credentials as a standalone library. This might transition into a separate project proposal in the future, underscoring the commitment to modular and reusable components in the digital identity space. | ||
|
||
# Alignment with the OpenWallet Foundation Mission | ||
The wallet-framework-dotnet directly aligns with the OpenWallet Foundation mission by offering an open-source solution that will advance the state of digital identity wallets. The project's focus on implementing OpenID4VC in conjunction with the European Identity Wallet initiative underscores our commitment to global, interoperable standards, and enhances trust and security in digital identity systems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any plans to expand the wallet beyond identity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet, we will focus on identity and verifiable credentials
The wallet-framework-dotnet directly aligns with the OpenWallet Foundation mission by offering an open-source solution that will advance the state of digital identity wallets. The project's focus on implementing OpenID4VC in conjunction with the European Identity Wallet initiative underscores our commitment to global, interoperable standards, and enhances trust and security in digital identity systems. | ||
|
||
# Current Code of Conduct | ||
tbd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be willing to adopt the LF EU Code of Conduct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we would
# Source Control | ||
To be established (Expected: https://github.com/openwallet-foundation/wallet-framework-dotnet) | ||
|
||
Suceeds Hyperledger Aries project: [aries-framework-dotnet](https://github.com/hyperledger/aries-framework-dotnet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the plan be to transfer the repo from Hyperledger to OWF? Or would the intention be to archive the one in Hyperledger and start with a new repo in OWF?
# Communication Channels | ||
To be established. (Discord Channel in OWF) | ||
|
||
# Project Website |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is intended to represent if there is an existing website for the project that we need to be aware of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I would add the current repository at aries here
|
||
|
||
# Infrastructure | ||
- Requires build and release pipeline for the Nuget package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be handled by GitHub Actions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally have experience with Azure Devops, but I am certain that GitHub Actions would also work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ntsbs please don't use ADO - Microsoft's stated plan is to EOL ADO once GHA has all the features of ADO. It is also harder to manage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay with Github Actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ntsbs Will this be a possible solution?
You can configure the dotnet command-line interface (CLI) to publish NuGet packages to GitHub Packages and to use packages stored on GitHub Packages as dependencies in a .NET project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this can be set up with OWF, I am happy to do so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this isn't explicit, the OWF project lifecycle says that " Labs will receive minimal support from the Foundation". Is this pipeline support acceptable to the TAC for labs projects?
That being said, I think this project could easily apply for growth status, as I've said below.
|
||
Currently, the framework supports DidComm v1 and AnonCreds. There is an active intention to extend support for other promising protocols, notably DidComm v2, to ensure the framework remains at the forefront of digital identity solutions. | ||
|
||
Furthermore, the team is considering the development of SD-JWT credentials as a standalone library. This might transition into a separate project proposal in the future, underscoring the commitment to modular and reusable components in the digital identity space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also support having native SD-JWT implementation in different technologies. It's good however to see an alignment between all these projects: For example, share the same test scenarios and exercise their code base over them.
|
||
Currently, the framework supports DidComm v1 and AnonCreds. There is an active intention to extend support for other promising protocols, notably DidComm v2, to ensure the framework remains at the forefront of digital identity solutions. | ||
|
||
Furthermore, the team is considering the development of SD-JWT credentials as a standalone library. This might transition into a separate project proposal in the future, underscoring the commitment to modular and reusable components in the digital identity space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider extracting the SD-JWT part into its own building block (library) and repository?
# Issue Tracker | ||
GitHub Issues | ||
|
||
# External Dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we check the license of these dependencies for compatibility with Apache 2.0 and re-licensing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All other Aries projects that we currently depend on are licensed under Apache-2.0
|
||
|
||
# Infrastructure | ||
- Requires build and release pipeline for the Nuget package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ntsbs Will this be a possible solution?
You can configure the dotnet command-line interface (CLI) to publish NuGet packages to GitHub Packages and to use packages stored on GitHub Packages as dependencies in a .NET project.
- Christopher Hempel [CHempel-esatus](https://github.com/CHempel-esatus) | ||
|
||
# Proposed Project Governance | ||
tbd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you all want to ask the LF project/legal team for your own charter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are not as many stakeholders, the governance was so far not an issue. Are there any references with regard to the governance of other projects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OWF is a "new" LF foundation, and new LF foundations generally encourage projects to have their own charters written. Hyperledger is an "old" foundation, and has rules that are different (but not encouraged for new foundations these days).
A charter can help you get more contributors and maintainers by explicitly laying out governance rules, making it easier for outsiders to see how to get involved.
tbd | ||
|
||
# Preferred Maturity Level | ||
Labs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you all are applying for labs status and not growth? You will not get some project services as a labs project that you currently have as a part of Aries (e.g. CI/CD, security programs, etc.). While I can't speak for the TAC, it may make sense to consider applying as a growth project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought Labs is the general entry state and a project will be promoted to growth if it gets more adoption
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can apply for any status that you want. There are no guarantees that you'll get it, but you can always ask the TAC.
Labs might be the default status for new projects without much code, but you all aren't submitting a "new" open source project.
@@ -0,0 +1,65 @@ | |||
# Project Name | |||
Wallet Framework .NET (wallet-framework-dotnet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name probably isn't going to work if you want to become a growth or impact project, as there will most likely be trademark issues. Are you all OK with renaming to something more distinctive (or trademarkable)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are your concerns mostly due to .NET? Maybe wallet-framework-csharp would be an alternative
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, my concerns are mostly due to the distinctiveness of the name.
Signed-off-by: Sebastian Bickerle <sebastian.bickerle@neosfer.com>
@ntsbs : Could you please update this branch so that we can merge the project proposal? |
Approved by TAC on October 4, 2023 |
No description provided.