Fix: handle API Key error in reducer #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josadcha
suggested changes
Jan 19, 2021
seanyellowd
force-pushed
the
fix/apikey-error
branch
from
8366888
to
23a539e
Compare
josadcha
approved these changes
Jan 20, 2021
|
so please, add dataLoaded for actions as I asked you. If post actions are successful redux state should be updated. In ApiKeys container there is a check if data has been loaded |
seanyellowd
force-pushed
the
fix/apikey-error
branch
from
23a539e
to
9da8dce
Compare
akhlopiachyi
approved these changes
Jan 20, 2021
calj
pushed a commit
that referenced
this pull request
Feb 2, 2021
* Fix: handle api key error in reducer * Fix: add success value into apiKeys redux state * Fix: remove unnecessary success redux Co-authored-by: Sean Lee <5255084-seanlee1@users.noreply.gitlab.com>
oyershov
pushed a commit
that referenced
this pull request
Feb 2, 2021
* Fix: handle api key error in reducer * Fix: add success value into apiKeys redux state * Fix: remove unnecessary success redux Co-authored-by: Sean Lee <5255084-seanlee1@users.noreply.gitlab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proper redux state fixes the bug.
https://jira.openware.work/browse/EMI-320