Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: phone verification sendcode logic should cover resend too #420

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Fix: phone verification sendcode logic should cover resend too #420

merged 2 commits into from
Jan 22, 2021

Conversation

seanyellowd
Copy link
Contributor

@seanyellowd seanyellowd commented Jan 21, 2021 •
edited
Loading

https://jira.openware.work/browse/EMI-329

How to test phone verification:
mocks/api/v2/barong/resource/labels/GET.mock

  {
      "key":"phone",
      "value":"",
      ...
   },
  {
      "key":"profile",
      "value":"",
      ...
   },
  {
      "key":"document",
      "value":"",
      ...
   },

phone_number: +1111
mock data: Verified phone_number exists
mocks/api/v2/barong/resource/phones/POST--phone_number=+1111.mock

phone_number: +1234
mock data: Unverified phone_number exists. So, put resendCode.
mocks/api/v2/barong/resource/phones/POST--phone_number=+1234.mock

@seanyellowd seanyellowd added the Ready Ready for a review label Jan 21, 2021
josadcha
josadcha suggested changes Jan 21, 2021
View reviewed changes
src/modules/user/kyc/phone/sagas/sendCodeSaga.ts Outdated Show resolved Hide resolved
src/modules/user/kyc/phone/sagas/sendCodeSaga.ts Outdated Show resolved Hide resolved
@josadcha josadcha added Required: Fix Need to fix a code and removed Ready Ready for a review labels Jan 21, 2021
@seanyellowd seanyellowd added Ready Ready for a review and removed Required: Fix Need to fix a code labels Jan 22, 2021
@akushniruk akushniruk added the Tech: Approved Approved by tech lead label Jan 22, 2021
@josadcha josadcha merged commit 2f774eb into master Jan 22, 2021
@josadcha josadcha deleted the fix/phone-verification-resend-code branch January 22, 2021 10:02
calj pushed a commit that referenced this pull request Feb 2, 2021
@seanyellowd
Fix: phone verification sendcode logic should cover resend too (#420)
eba9fdc 
* Fix: phone verification sendcode logic should cover resend too

* Fix: resend code if unverified phone_number exists

Co-authored-by: Sean Lee <5255084-seanlee1@users.noreply.gitlab.com>
oyershov pushed a commit that referenced this pull request Feb 2, 2021
@seanyellowd @oyershov
Fix: phone verification sendcode logic should cover resend too (#420)
d66f3d3 
* Fix: phone verification sendcode logic should cover resend too

* Fix: resend code if unverified phone_number exists

Co-authored-by: Sean Lee <5255084-seanlee1@users.noreply.gitlab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akushniruk akushniruk akushniruk approved these changes

@josadcha josadcha josadcha approved these changes

@akhlopiachyi akhlopiachyi Awaiting requested review from akhlopiachyi

Assignees
No one assigned
Labels
Ready Ready for a review Tech: Approved Approved by tech lead
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seanyellowd @akushniruk @josadcha