Feature: add plugin system, add IEO plugin #607
Conversation
|
SonarCloud Quality Gate failed.
|
| [ | ||
| { | ||
| "name": "ieo" | ||
| } | ||
| ] |
There was a problem hiding this comment.
I don't think we should have IEO plugin enabled by default, keep this file empty
|
|
||
| export const PG_TITLE_PREFIX = 'Cryptobase'; | ||
|
|
||
| export const pgRoutes = (isLoggedIn: boolean, isLight?: boolean): string[][] => { | ||
| export const pgRoutes = (isLoggedIn: boolean, Plugins: PluginsManager, isLight?: boolean): string[][] => { |
There was a problem hiding this comment.
this file will have conflicts with P2P PR, could we please merge this PR after P2P patch?
| @@ -87,10 +88,14 @@ class SidebarContainer extends React.Component<Props, State> { | |||
| 'pg-sidebar-wrapper--hidden': !isActive, | |||
| }); | |||
|
|
|||
| const imageSrc = this.tryRequireRoot(lang) | |||
There was a problem hiding this comment.
imageSrc is declared but not used anywhere
| private tryRequireRoot = (name: string) => { | ||
| try { | ||
| require(`../../assets/images/sidebar/${name}.svg`); | ||
|
|
||
| return true; | ||
| } catch (err) { | ||
| return false; | ||
| } | ||
| }; | ||
|
|
||
| private tryRequirePlugins = (name: string) => { | ||
| try { | ||
| require(`../../plugins/assets/images/${name}.svg`); | ||
|
|
||
| return true; | ||
| } catch (err) { | ||
| return false; | ||
| } | ||
| }; |
There was a problem hiding this comment.
make a common func that accepts src address as argument
| @@ -118,7 +119,7 @@ export const marketStreams = (market: Market) => { | |||
| ]; | |||
|
|
|||
| if (incrementalOrderBook()) { | |||
| store.dispatch(depthIncrementSubscribe(market.id)); | |||
| store(Plugins.getReduxReducer()).dispatch(depthIncrementSubscribe(market.id)); | |||
There was a problem hiding this comment.
does WS work as expected with this patch?
| ```javascript | ||
| plugins: [{ | ||
| name: 'ieo', | ||
| config: { | ||
| fields: { | ||
| name: 'IEO', | ||
| description: true, | ||
| ratio: true, | ||
| metadata: true, | ||
| }, | ||
| } | ||
| }] | ||
| ``` | ||
|
|
||
| In order to have **Auctions** plugin set these to `env.js` | ||
|
|
||
| ```javascript | ||
| plugins: [{ | ||
| name: 'ieo', | ||
| config: { | ||
| fields: { | ||
| name: 'Auctions', | ||
| description: false, | ||
| ratio: false, | ||
| metadata: false, | ||
| }, | ||
| } | ||
| }] |
There was a problem hiding this comment.
As I remember baseapp side doesn't listen for additional IEO configuration, could you please update README
akushniruk
added
Outdated
and removed
Ready
|
need rewrite to new react 18 etc |
|
moved to baseapp-aurora |
No description provided.