Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Priority 3] ESLINT #378

Closed
wants to merge 6 commits into from
Closed

[Priority 3] ESLINT #378

wants to merge 6 commits into from

Conversation

berezh
Copy link
Contributor

@berezh berezh commented Nov 3, 2020

No description provided.

@berezh berezh added the WIP Work in progress label Nov 3, 2020
@berezh berezh changed the base branch from master to move-to-webpack November 3, 2020 18:03
@berezh berezh added Ready Ready for a review and removed WIP Work in progress labels Nov 4, 2020
@berezh berezh requested review from oyershov, josadcha, VladyslavP, akhlopiachyi and mod and removed request for oyershov November 4, 2020 12:18
@berezh
Copy link
Contributor Author

berezh commented Nov 4, 2020 •
edited

@mod @calj @akhlopiachyi @oyershov @josadcha @VladyslavP

I have unlinked @openware/coding-standards from the current project. Because it has tslint which is not matched with eslint.

Ideally @openware/coding-standards should be a plugin which added to eslint settings as described here - openware/coding-standards#3

@berezh berezh requested a review from calj November 4, 2020 17:00
@berezh berezh linked an issue Nov 10, 2020 that may be closed by this pull request
tslint => eslint migration #376
Closed
@berezh berezh changed the title ESLINT [Priority 1] ESLINT Nov 11, 2020
@berezh berezh changed the title [Priority 1] ESLINT [Priority 3] ESLINT Nov 11, 2020
@akhlopiachyi akhlopiachyi self-requested a review December 4, 2020 08:23
oyershov
oyershov reviewed Dec 4, 2020
View reviewed changes
Copy link
Contributor

@oyershov oyershov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope here only linter fixes...
image

@vpoberezh
Copy link

There are only ESLINT fixes

@calj calj closed this Dec 9, 2020
@calj
Copy link
Member

calj commented Dec 9, 2020

If we merge such PR it will be impossible to update any existing project.
Refactoring is a decision that need to be taken as a team.

@vshatravenko vshatravenko deleted the eslint branch February 23, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyershov oyershov oyershov left review comments

@josadcha josadcha Awaiting requested review from josadcha

@VladyslavP VladyslavP Awaiting requested review from VladyslavP

@mod mod Awaiting requested review from mod

@calj calj Awaiting requested review from calj

@akhlopiachyi akhlopiachyi Awaiting requested review from akhlopiachyi

Assignees
No one assigned
Labels
Ready Ready for a review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tslint => eslint migration
5 participants
@berezh @vpoberezh @calj @oyershov @akhlopiachyi