Move health probes to Grape API v2 (closes #2066) (#2071)

app/api/v2/public/tools.rb

@@ -21,6 +21,18 @@ class Tools < Grape::API
             present OpenStruct.new(v), with: Entities::Version
           end
         end
+
+        resource :health do
+          desc 'Get application liveness status'
+          head "/alive" do
+            status Services::HealthChecker.alive? ? 200 : 503
+          end
+
+          desc 'Get application readiness status'
+          head "/ready" do
+            status Services::HealthChecker.ready? ? 200 : 503
+          end
+        end
       end
     end
   end

config/routes.rb

@@ -55,9 +55,6 @@ def draw(routes_name)
     end
   end
 
-  get 'health/alive', to: 'public/health#alive'
-  get 'health/ready', to: 'public/health#ready'
-
   get 'trading/:market_id', to: BlackHoleRouter.new, as: :trading
 
   draw :admin

spec/api/v2/public/tools_spec.rb

@@ -10,4 +10,30 @@
       expect(JSON.parse(response.body)).to be_between(now.iso8601, (now + 1).iso8601)
     end
   end
+
+  describe '/health' do
+    it 'returns successful liveness probe' do
+      head '/api/v2/public/health/alive'
+      expect(response).to be_success
+    end
+
+    it 'returns failed liveness probe' do
+      Market.stubs(:connected?).returns(false)
+
+      head '/api/v2/public/health/alive'
+      expect(response).to have_http_status(503)
+    end
+
+    it 'returns successful readiness probe' do
+      head '/api/v2/public/health/ready'
+      expect(response).to be_success
+    end
+
+    it 'returns failed readiness probe' do
+      Bunny.stubs(:run).returns(false)
+
+      head '/api/v2/public/health/alive'
+      expect(response).to have_http_status(503)
+    end
+  end
 end