Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bech32 addresses #1498

Closed
TheHolyRoger opened this issue Aug 1, 2018 · 3 comments
Closed

Support bech32 addresses #1498

TheHolyRoger opened this issue Aug 1, 2018 · 3 comments

Comments

@TheHolyRoger
Copy link

The Bech32 address limit is 90 characters, peatio needs some changes to support this.

RAW SQL:
ALTER TABLE deposits MODIFY address VARCHAR(90);
ALTER TABLE payment_addresses MODIFY address VARCHAR(90);
ALTER TABLE withdraws MODIFY rid VARCHAR(90);

Affected files:
db/schema.rb Lines 77, 168, 233
app/models/deposit.rb Lines 79
app/models/payment_address.rb Lines 41
app/models/withdraw.rb Lines 151
app/models/deposits/coin.rb Lines 44
app/models/deposits/fiat.rb Lines 24
app/models/withdraws/coin.rb Lines 70
app/models/withdraws/fiat.rb Lines 26

Will also need a migrate file

@ysv
Copy link

ysv commented Aug 20, 2018

@TheHolyRoger Thanks
Agree I will left bech32 specification here

@dinesh-skyach
Copy link

@ysv I have checked regarding some popular coins address formats and i found Monero is only exception here with 95 characters length except that i didn't found any address exceeding 90 characters.

You can generate Monero address here

@ysv
Copy link

ysv commented Sep 26, 2018

closed in #1701

@ysv ysv closed this as completed Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants