Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Funds not moved from hot to warm wallet #1653

Closed
mseroka opened this issue Sep 6, 2018 · 1 comment · Fixed by #1735
Closed

Funds not moved from hot to warm wallet #1653

mseroka opened this issue Sep 6, 2018 · 1 comment · Fixed by #1735
Labels
Priority: Middle Type: Feature

Comments

@mseroka
Copy link

mseroka commented Sep 6, 2018

In order to replicate the issue:

  1. Set up a hot wallet for BTC.
  2. Make a deposit below the maximum of the hot wallet balance.
  3. Confirm the funds are collected and moved (in full) to the hot wallet (which is expected).
  4. Set up a warm wallet.
  5. Decrease the maximum balance of the hot wallet below its current balance (e.g. set it to 0.00000001).
  6. Confirm no funds are moved to the warm wallet even though the balance exceeds the maximum (unexpected behaviour Simple runtime for renovation #1).
  7. Make another deposit.
  8. Confirm the funds are collected and moved (in full) to the hot wallet - even though the maximum balance was already exceeded (unexpected behaviour updated gem file and added mysql adapter #2).
@mseroka
Copy link
Author

mseroka commented Sep 6, 2018

@mod: FYI - as discussed on Telegram.

This was referenced Oct 10, 2018
Merged
Merged
@mod mod closed this as completed in #1735 Nov 26, 2018
mod pushed a commit that referenced this issue Nov 26, 2018
Implement skimming deposit collection mechanism based on wallet max_b…
e3d83a6 
…alance (closes #1653) (#1735)

* Added Wallet Service Specs

* Implement skimming deposit collection mechanism for bitcoin

* Implement skimming deposit collection mechanism for eth

* Implement skimming deposit collection mechanism for ripple

* Enumerize Wallet kind

* Edit skiming mechanism for ripple wallet

* Edit skiming mechanism for eth wallet

* Use hash instead array for deposit collections

* Update specs with new skiming mechanism and add specs for ripple

* Add min_collection_amount method to currency

* Move load_balance! request to blockchain service and add specs for wallet service

* Add min_collection_amount column to currency and move spread deposit method to protected
mnaichuk pushed a commit to mnaichuk/peatio that referenced this issue Nov 29, 2018
Implement skimming deposit collection mechanism based on wallet max_b…
170ea6c 
…alance (closes openware#1653) (openware#1735)

* Added Wallet Service Specs

* Implement skimming deposit collection mechanism for bitcoin

* Implement skimming deposit collection mechanism for eth

* Implement skimming deposit collection mechanism for ripple

* Enumerize Wallet kind

* Edit skiming mechanism for ripple wallet

* Edit skiming mechanism for eth wallet

* Use hash instead array for deposit collections

* Update specs with new skiming mechanism and add specs for ripple

* Add min_collection_amount method to currency

* Move load_balance! request to blockchain service and add specs for wallet service

* Add min_collection_amount column to currency and move spread deposit method to protected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Middle Type: Feature
Milestone
No milestone
2 participants
@mseroka @ysv