Feature: add admin currencies fetch filters #2678
Conversation
| @@ -112,7 +112,12 @@ class Currencies < Grape::API | |||
| get '/currencies' do | |||
| admin_authorize! :read, Currency | |||
|
|
|||
| search = Currency.ransack(type_eq: params[:type]) | |||
| ransack_params = Helpers::RansackBuilder.new(params) | |||
| .eq(:type, :deposit_enabled, :withdrawal_enabled, :visible) | |||
There was a problem hiding this comment.
you should add new params in params section: check line 108 and example you can see at line 189
There was a problem hiding this comment.
no, should be like:
deposit_enabled: {
type: { value: Boolean, message: 'admin.currency.non_boolean_deposit_enabled' },
default: true,
desc: -> { API::V2::Admin::Entities::Currency.documentation[:deposit_enabled][:desc] }
}
for all params that you added
spec/api/v2/admin/currencies_spec.rb
Outdated
| @@ -86,6 +86,38 @@ | |||
| expect(result.dig(0, :code)).to eq 'eur' | |||
| end | |||
|
|
|||
| it 'list of deposit_enabled currencies' do | |||
| @@ -112,7 +112,12 @@ class Currencies < Grape::API | |||
| get '/currencies' do | |||
| admin_authorize! :read, Currency | |||
|
|
|||
| search = Currency.ransack(type_eq: params[:type]) | |||
| ransack_params = Helpers::RansackBuilder.new(params) | |||
| .eq(:type, :deposit_enabled, :withdrawal_enabled, :visible) | |||
There was a problem hiding this comment.
no, should be like:
deposit_enabled: {
type: { value: Boolean, message: 'admin.currency.non_boolean_deposit_enabled' },
default: true,
desc: -> { API::V2::Admin::Entities::Currency.documentation[:deposit_enabled][:desc] }
}
for all params that you added
| @@ -86,6 +86,70 @@ | |||
| expect(result.dig(0, :code)).to eq 'eur' | |||
| end | |||
|
|
|||
| it 'list of deposit enabled currencies' do | |||
There was a problem hiding this comment.
after you will add params declaration you need to negative cases like if you will send params with the wrong type, check pls line 153:
it 'returns error in case of invalid type' do
api_get '/api/v2/admin/currencies', params: { type: 'invalid' }, token: token
expect(response).to have_http_status 422
end
spec/api/v2/admin/currencies_spec.rb
Outdated
| expect(response).to be_successful | ||
|
|
||
| result = JSON.parse(response.body) | ||
| expect(result.size).to eq Currency.coins.select { |c| c['visible'] == false }.count |
There was a problem hiding this comment.
just FYI you can use Currency.coins.where(visible: false)
|
please rebase |
oyershov
force-pushed
the
feature/admin-currency-filters
branch
from
e8723c4
to
06a44ba
Compare
No description provided.