Improvements for legacy benchmark tools (closes #1249) #1254
Conversation
lib/profiling/execution.rb
Outdated
| @@ -0,0 +1,53 @@ | |||
| require 'benchmark/amqp_mock' | |||
| require 'ruby-prof' | |||
There was a problem hiding this comment.
@dinesh-skyach you must find a way to avoid code duplication
profiler should go in benchmark, improve benchmark usage eventually to configure smaller runs
Gemfile
Outdated
| @@ -72,6 +72,7 @@ end | |||
|
|
|||
| group :development do | |||
| gem 'annotate', '~> 2.7' | |||
| gem 'ruby-prof' | |||
There was a problem hiding this comment.
NEVER NEVER NEVER omit VERSION, AND DON'T require uneeded deps
There was a problem hiding this comment.
@dinesh-skyach you misunderstand me,
we need the existing benchmark to be able to support profiling
we can do
# will run regular benchmark
rake benchmark:matching
# Will run the same benchmark code with ruby-prof
# lower number of rounds and count
rake profiling:matching
|
@mod I didn't get what you mean by "Will run the same benchmark code with ruby-prof". The code is almost the same only the difference is that we need to run the benchmark under Benchmark.benchmark { } block and 'ruby-prof' under RubyProf.profile { } block. Also for this "rake profiling:matching" currently to run this we use rake benchmark:profiling['matching']. Here you mean to change this to rake profiling:matching. |
yivo
changed the title
|
you are duplicating code can you make the feature without duplicating the code ? |
|
@mod we need different files for profiling and benchmark, as they run under different blocks and also as we use 'ruby-prof' gem and this prints very large output because it tracks the recursively called methods. So we save the output in a file. |
|
@dinesh-skyach I still think you could have refactored the code in order to get less repeating code |
Improvements for legacy benchmark tools #1249