Add API endpoint for currencies #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysv
suggested changes
Jul 17, 2018
app/api/api_v2/currencies.rb
Outdated
| optional :type, type: String, values: %w[fiat coin], desc: 'Type of currency. Available values: coin, fiat' | ||
| end | ||
| get '/currencies' do | ||
| if params[:type].nil? |
app/api/api_v2/entities/currency.rb
Outdated
|
|
||
| expose :base_factor, documentation: 'Currency base factor' | ||
| expose :precision, documentation: 'Currency precision' | ||
| end |
There was a problem hiding this comment.
expose only:
id, symbol, type, deposit_fee, withdraw_fee, quick_withdraw_limit, deposit_confirmations, allow_multiple_deposit_addresses, base_factor, precision
ysv
approved these changes
Jul 17, 2018
ysv
suggested changes
Jul 18, 2018
spec/api/api_v2/currencies_spec.rb
Outdated
| @@ -67,10 +66,67 @@ | |||
|
|
|||
| after { KlineDB.redis.flushall } | |||
|
|
|||
| RSpec::Matchers.define :have_trade_structure do | |||
| match { |x| not (x.dig(:price).nil? || x.dig(:volume).nil? || x.dig(:change).nil?) } | |||
There was a problem hiding this comment.
match { |x| x[:price].present? && x[:volume].present? && x[:change].present? }
|
Please update doc https://github.com/rubykube/peatio/blob/master/docs/api/member_api_v2.md |
|
@ysv Travis CI will do this for us. |
|
@shal I don't think we run bump in master |
|
@ysv you won 😄 |
|
@ysv I updated member API documentation according to this patch. |
|
@ysv Ready. |
|
@shal looks good for me |
|
@ysv Please, push this PR into |
ymasiuk
pushed a commit
to ymasiuk/peatio
that referenced
this pull request
Jul 20, 2018
* Add API endpoint for currencies * Prettify code for currency/trades endpoint * Prettify tests for currency/trades endpoint * Finish * Fix spec * Add one more spec of currency structure * Fix typo * Add documentation about added currency API * Fix
mod
pushed a commit
that referenced
this pull request
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.