[Experimental] Upgrade To Rails 5.2 #1979
Conversation
|
Bring it on dudes ASAP, for both v1.9 and v2.0 please. |
|
@dinesh-skyach Could you rebase the patch? |
| gem 'ruby-prof', '~> 0.17.0', require: false | ||
| gem 'annotate', '~> 2.7.4' | ||
| gem 'ruby-prof', '~> 0.17.0', require: false | ||
| gem 'spring', '~> 2.0.2' |
There was a problem hiding this comment.
@dinesh-skyach Why do we need this gems: spring and spring-watcher-listen?
| gem 'factory_bot_rails', '~> 4.11.1' | ||
| gem 'timecop', '~> 0.9.1' | ||
| gem 'rubocop-rspec', '~> 1.31.0', require: false | ||
| gem 'rails-controller-testing', '~> 1.0.4' |
There was a problem hiding this comment.
I think later we should have a separate task to get rid of rails-controller-testing.
rails/rails#1895
| @@ -35,7 +35,7 @@ class Order < ActiveRecord::Base | |||
|
|
|||
| after_commit on: :update do | |||
| next unless ord_type == 'limit' | |||
| event = case previous_changes.dig('state', 1) | |||
| event = case state | |||
There was a problem hiding this comment.
Maybe let's keep:
event = case after_save.dig('state', 1)| # path to your application root | ||
| APP_ROOT = File.expand_path('../../', __FILE__) | ||
| require 'fileutils' | ||
| include FileUtils |
There was a problem hiding this comment.
I don't this is it necessary to include and require FileUtils. Just keep
Dir.chdir APP_ROOT do
...
end| require 'rails' | ||
|
|
||
| %w( active_record action_controller action_view sprockets ).each { |framework| require "#{framework}/railtie" } | ||
| require 'rails/all' |
There was a problem hiding this comment.
I afraid amount of unused libs may speed down the application.
There was a problem hiding this comment.
Keep this:
require_relative 'boot'
require 'rails'
%w( active_record action_controller action_view sprockets ).each { |framework| require "#{framework}/railtie" }| @@ -0,0 +1 @@ | |||
| nvyOF/IyR5uU8ouBSuMUepwoSYJbiAJ5uK+jXqp/Uy2s0BEktlGaRACEBxu+rAdiSNVAwKfm+/2ZSiBd4QXTZa8YGLOPTBjKhL9xoT8EFtLLngTp2KIz367L4dtCWZ2Cdv9Fqf4bnZtSKnPXk4oECN0OnsCmiUInZW4bVU9E5jFqTsAyzuD8P1KOkmFvjJAHxbuO/w1tuLiKW253DZhdtbW4LHABgUFagnPUym6jHnMec272zfjsrFhYSjFWeWGg1qIBwRow/l3f30HR93X0cXqCWv5CCgDOAElrxQEWJ3P5SnYEydt9t8IDvw9cSnmS5aPpzMxOqw7PB7bA4I8BW2tgmpi364I1UWSU1Nd2co3hOR5pmIpb7etbJJfC1jw/4Ai9qVQHeMqNXUDBO2uVR9JbKq7v3nnjP1A1--d4xxvUu/a12DL/sR--sJ1yQRmZFkqaGVQYVM1J7A== | |||
| # Show full error reports and disable caching. | ||
| config.consider_all_requests_local = true | ||
| # Show full error reports. | ||
| config.consider_all_requests_local = true |
| # yet still be able to expire them through the digest params. | ||
| config.assets.digest = true | ||
| # Suppress logger output for asset requests. | ||
| config.assets.quiet = true |
There was a problem hiding this comment.
Try:
config.logger = ActiveSupport::Logger.new(STDOUT)
config.assets.quiet = true
|
@dinesh-skyach @mod In my opinion this patch is very dangerous, it is too difficult to review all this changes and I think impossible to check everything. Here is quote from rails main page: Let start from https://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-4-2-to-rails-5-0 and then keep bumping the version slowly 😸 |
|
Closed via #2095. |
Upgrade To Rails 5.2