Rewrite callbacks for avoid using redirect_to :back #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysv
reviewed
Mar 12, 2019
| @@ -21,7 +21,7 @@ def create | |||
| if @blockchain.save | |||
| redirect_to admin_blockchains_path | |||
| else | |||
| flash[:alert] = @blockchain.errors.full_messages | |||
| flash[:alert] = @blockchain.errors.full_messages.first | |||
There was a problem hiding this comment.
@ysv without .first we will see error like ["ERROR_TEXT"] with .first it would be just like string without any characters.
|
@ymasiuk Create issue please |
|
@ymasiuk Please rebase, your patch doesn't work now. |
ymasiuk
force-pushed
the
redirect-to-back
branch
from
afeb0e7
to
95050a5
Compare
|
@shal done |
ysv
approved these changes
Apr 2, 2019
mnaichuk
pushed a commit
to mnaichuk/peatio
that referenced
this pull request
Apr 10, 2019
mod
pushed a commit
that referenced
this pull request
Apr 18, 2019
* Change redirect_to to render (#2113) * Rewrite callbacks for avoid using redirect_to :back
mnaichuk
pushed a commit
to mnaichuk/peatio
that referenced
this pull request
Apr 19, 2019
* Change redirect_to to render (openware#2113) * Rewrite callbacks for avoid using redirect_to :back
mnaichuk
pushed a commit
that referenced
this pull request
Apr 19, 2019
* Change redirect_to to render (#2113) * Rewrite callbacks for avoid using redirect_to :back
mnaichuk
pushed a commit
to mnaichuk/peatio
that referenced
this pull request
Apr 19, 2019
* Change redirect_to to render (openware#2113) * Rewrite callbacks for avoid using redirect_to :back
mnaichuk
pushed a commit
to mnaichuk/peatio
that referenced
this pull request
Apr 19, 2019
* Change redirect_to to render (openware#2113) * Rewrite callbacks for avoid using redirect_to :back
mod
pushed a commit
that referenced
this pull request
Apr 22, 2019
* Change redirect_to to render (#2113) * Rewrite callbacks for avoid using redirect_to :back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.