Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Ruby on Rails to 5.2 #2146

Merged
merged 1 commit into from Apr 2, 2019
Merged

Upgrade Ruby on Rails to 5.2 #2146

merged 1 commit into from Apr 2, 2019

Conversation

ysv
Copy link

@ysv ysv commented Mar 28, 2019 •
edited

closes #2056

@ysv ysv changed the title Upgrade Ruby on Rails to 5.0 Upgrade Ruby on Rails to 5.2 Mar 28, 2019
ysv
ysv commented Mar 29, 2019
View reviewed changes
config/application.rb
@@ -5,7 +5,7 @@

require 'rails'

%w( active_record action_controller action_view sprockets ).each { |framework| require "#{framework}/railtie" }
%w( active_record action_controller action_view active_job sprockets ).each { |framework| require "#{framework}/railtie" }
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if it possible to start rails without active_job

config/database.yml Outdated
@@ -20,4 +20,4 @@ production:
<<: *default
url: <%= ENV['DATABASE_URL'] %>
pool: 10
database: <%= ENV.fetch('DATABASE_NAME', 'peatio_production') %>
database: <%= ENV.fetch('DATABASE_NAME', 'peatio_development') %>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reset

config/secrets.yml Outdated
@@ -19,4 +19,4 @@ test:
# Do not keep production secrets in the repository,
# instead read values from the environment.
production:
secret_key_base: <%= ENV["SECRET_KEY_BASE"] %>
secret_key_base: 2c3cdc3e0bc14d5260250570be0961de2f974c4f3e15b6004734d9e587ce9f47da248f20dc1707a5bb555d879a5494641f4b1a01ca6066df2b783943914ebcd7
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reset

@ysv ysv added PR: Approved and removed PR: QA labels Apr 2, 2019
@mod mod merged commit c633672 into master Apr 2, 2019
@mod mod deleted the enhancement/rails-5.2 branch April 2, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Approved v2.1
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to rails 5.2
2 participants
@ysv @mod