Plugable coins API #2168
Merged
Plugable coins API #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysv
force-pushed
the
feature/plugable-blockchains-2
branch
3 times, most recently
from
6cfa0e3
to
4f2a898
Compare
mnaichuk
force-pushed
the
feature/plugable-blockchains-2
branch
2 times, most recently
from
30940c6
to
c55954d
Compare
ysv
commented
Apr 15, 2019
mnaichuk
force-pushed
the
feature/plugable-blockchains-2
branch
from
8b6d607
to
e3843e8
Compare
ysv
commented
Apr 16, 2019
app/models/deposit.rb
Outdated
| AMQPQueue.enqueue(:deposit_collection, id: id) | ||
| end | ||
| end | ||
| AMQPQueue.enqueue(:deposit_collection_fees, id: id) if coin? && collect_fee |
There was a problem hiding this comment.
we still need to publish to deposit_collection if collect_fee is false
|
Outdated |
ysv
force-pushed
the
feature/plugable-blockchains-2
branch
2 times, most recently
from
108db1d
to
f939e2a
Compare
ysv
force-pushed
the
feature/plugable-blockchains-2
branch
from
4d5f833
to
23d9e37
Compare
…opment doc (#2210) * add local peatio-litecoin * WIP Litecoin plugin integration * Replace initializer/faraday with better-faraday gem * Fix Dockerfile * [WIP] Currency plugin development and integration doc * [skip ci] [WIP] Plugin.md doc * [skip cli] Minor md changes * [skip cli] Minor md changes 2 * plugin.md rc-1 * Minor md changes: * Minor md changes 4 * Add more examples * Move coin specific doc to doc/currencies * [skip ci] Rename to doc/currencies to doc/coins * [ci skip] doc integration * Use peatio-litecoin 0.1.0 * Mention in README * Update plugins.md
ysv
force-pushed
the
feature/plugable-blockchains-2
branch
from
39a71d7
to
0d42e44
Compare
mnaichuk
reviewed
May 22, 2019
app/services/blockchain_service.rb
Outdated
| @blockchain = blockchian | ||
| @adapter = Peatio::Blockchain.registry[blockchian.client.to_sym] | ||
| @adapter.configure(server: @blockchain.server, | ||
| currencies: @blockchain.currencies.map(&:to_blockchain_api_settings)) |
There was a problem hiding this comment.
I think we need to add @blockchain.currencies.enabled.map(&:to_blockchain_api_settings)), @ysv ?
| @wallet = wallet | ||
| @adapter = Peatio::Wallet.registry[wallet.gateway.to_sym] | ||
| @adapter.configure(wallet: @wallet.to_wallet_api_settings, | ||
| currency: @wallet.currency.to_blockchain_api_settings) |
mod
approved these changes
May 27, 2019
|
Finalization todo list:
|
This was referenced May 31, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finalization todo list:
closed #2045
closes #2155