Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for ability to disable UI (closes #549) #607

Merged
merged 1 commit into from Mar 2, 2018
Merged

Add specs for ability to disable UI (closes #549) #607

merged 1 commit into from Mar 2, 2018

Conversation

ysv
Copy link

@ysv ysv commented Feb 27, 2018

No description provided.

yivo
yivo suggested changes Feb 27, 2018
View reviewed changes
spec/controllers/private/markets_controller_spec.rb Outdated

before { ENV['DISABLE_MARKETS_UI'] = nil }

context 'when market UI enabled' do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yssavchuk UI is enabled.

spec/controllers/private/markets_controller_spec.rb Outdated
before { ENV['DISABLE_MARKETS_UI'] = nil }

context 'when market UI enabled' do
it 'should return ok (200)' do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yssavchuk It is better to use just code number 200 without message.

spec/controllers/private/markets_controller_spec.rb Outdated

context 'when market UI disabled' do
before { ENV['DISABLE_MARKETS_UI'] = 'true'}
it 'should return no_content (204)' do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yssavchuk should return HTTP 204 should be fine.

spec/controllers/welcome_controller_spec.rb Outdated
before { ENV['DISABLE_CABINET_UI'] = nil }

context 'when cabinet UI enabled' do
it 'should return ok (200)' do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yssavchuk the same.

spec/controllers/welcome_controller_spec.rb Outdated

context 'when cabinet UI disabled' do
before { ENV['DISABLE_CABINET_UI'] = 'true'}
it 'should return no_content (204)' do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yssavchuk the same.

@yivo yivo changed the title Add specs for ability to disable UI (closes #549) [WIP] Add specs for ability to disable UI (closes #549) Feb 27, 2018
@ysv ysv changed the title [WIP] Add specs for ability to disable UI (closes #549) \Add specs for ability to disable UI (closes #549) Feb 27, 2018
@ysv ysv changed the title \Add specs for ability to disable UI (closes #549) Add specs for ability to disable UI (closes #549) Feb 27, 2018
@mod mod merged commit 8c6cfdd into openware:master Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yivo yivo yivo requested changes

Assignees
No one assigned
Labels
PR: Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ysv @yivo @mod