Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bin/init_config & bin/link_config according to new config templates structure and updated requirements for config/seed (closes #642) #643

Merged
merged 1 commit into from Mar 11, 2018
Merged

Update bin/init_config & bin/link_config according to new config templates structure and updated requirements for config/seed (closes #642) #643

merged 1 commit into from Mar 11, 2018

Conversation

ysv
Copy link

@ysv ysv commented Mar 7, 2018

No description provided.

@yivo yivo added the PR: Review label Mar 7, 2018
@yivo
Copy link

yivo commented Mar 7, 2018

@yssavchuk Please, do the next:

  1. Move all configs to lib/config_templates
  2. They must respect actual structure: lib/config_templates/seed/currencies.yml.erb must be rendered into config/seed/currencies.yml. Paths must not be hardcoded, they must be calculated.
lib/config_templates
  deposit_channels.yml.erb
  withdraw_channels.yml.erb
  seed
    currencies.yml.erb

@yivo yivo added this to the 1.4 - JWT API upgrade milestone Mar 8, 2018
@yivo yivo changed the title Update link_config script due to moving currencies.yml (closes #642) Update bin/init_config & bin/link_config according to new config templates structure and updated requirements for config/seed (closes #642) Mar 10, 2018
@yivo
Update bin/init_config & bin/link_config according to new config temp…
2864490 
…lates structure and updated requirements for config/seed (closes openware#642).
@mod mod merged commit be6f597 into openware:master Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Approved
Milestone
1.4 - JWT API upgrade
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ysv @yivo @mod