Remove Deposit#fund_extra, Deposit#fund_uid and usages (fixes #803) #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yivo
suggested changes
Apr 9, 2018
| @@ -18,7 +18,6 @@ <h2 class="panel-title">{{ "funds.deposit_history.title" | t }}</h2> | |||
| <tr class="deposit_item" ng-class="{ 'new-row':dhCtrl.newRecord(deposit) }" ng-repeat="deposit in dhCtrl.deposits | orderBy:predicate"> | |||
| <td><span class="outlined-label">{{ deposit.id }}</span></td> | |||
| <td>{{ deposit.created_at | date:'yyyy-MM-dd HH:mm' }}</td> | |||
| <td>{{ deposit.fund_extra }} @ {{ deposit.fund_uid }}</td> | |||
There was a problem hiding this comment.
@k1T4eR This will not work. You should test it manually.
| @@ -7,12 +7,6 @@ | |||
| </div> | |||
| <div class="panel-body"> | |||
| <dl class="dl-horizontal dl-member"> | |||
| <dt>Bank</dt> | |||
There was a problem hiding this comment.
@k1T4eR Send me the screenshot of deposit form.
yivo
added
PR: Review
PR: QA
PR: Approved
and removed
PR: Changes needed
PR: WIP
PR: Review
PR: QA
labels
yivo
approved these changes
Apr 9, 2018
ysv
pushed a commit
to ysv/peatio
that referenced
this pull request
Apr 13, 2018
…e#803) (openware#820) * Remove Deposit#fund_extra, Deposit#fund_uid and usages * Remove fund_ui fund_extra_text from locales. * Remove 'deposit_history.from' column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.