This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
Address Github Issue 238 #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerickson
requested review from
jaylogue,
robszewczyk,
Vyrastas,
pidarped,
emargolis,
yunhanw-google,
jenniexie and
suryanshup
robszewczyk
approved these changes
May 27, 2019
jaylogue
approved these changes
May 28, 2019
gerickson
force-pushed
the
bug/github-issue-238
branch
4 times, most recently
from
381d9fb
to
3619af1
Compare
added 2 commits
May 28, 2019 16:48
… the '--{enable,disable}-python' option. Always auto-generate the 'ASN1OID.h' header and, when generating, do so to the build directory, when builds are non-colocated.
gerickson
force-pushed
the
bug/github-issue-238
branch
from
3619af1
to
e41dfe3
Compare
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
+ Coverage 54.22% 54.23% +<.01%
==========================================
Files 332 332
Lines 56404 56404
==========================================
+ Hits 30587 30588 +1
+ Misses 25817 25816 -1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #238.