Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get CSS property values from webref #1033

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Get CSS property values from webref #1033

merged 3 commits into from
Jan 12, 2024

Conversation

queengooborg
Copy link
Member

@queengooborg queengooborg commented Jan 3, 2024

This PR grabs the values for CSS properties from webref, so that we can stay synchronized with new values introduced in the specification.

Statistics

Before this change, there are 1284 features in css.properties. After this change, there are 2510 features. This adds 1,226 new features and removes 0.

@queengooborg queengooborg temporarily deployed to mdn-bcd-collector-pr-1033 January 3, 2024 14:19 Inactive
@queengooborg queengooborg temporarily deployed to mdn-bcd-collector-pr-1033 January 3, 2024 14:21 Inactive
@queengooborg queengooborg temporarily deployed to mdn-bcd-collector-pr-1033 January 7, 2024 16:42 Inactive
Copy link
Member

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's try.

@teoli2003 teoli2003 merged commit 5d4c806 into main Jan 12, 2024
5 checks passed
@queengooborg queengooborg deleted the spec-css-values branch January 12, 2024 14:11
@Elchi3
Copy link
Member

Elchi3 commented Jan 15, 2024

Before this change, there are 1284 features in css.properties. After this change, there are 2510 features. This adds 1,226 new features and removes 0.

This is massive. I'm not yet sure we have the bandwidth to review this. Do you know how it will affect our coverage (which is a goal)?

Also, what is the plan for avoiding to introduce a lot of ranged values? For example if you have the CSS height property supported since version 1 and you add a sub feature for the height: auto value, which I think was a value that was also added in version 1, how will the collector do this? I often see the collector setting ≤72 for Firefox for example as the earliest version. This is problematic because MDN renders it as "72" which is not ideal as I think we should be indicating that height and height: auto were introduced at the same time, in version 1.

@queengooborg
Copy link
Member Author

Do you know how it will affect our coverage (which is a goal)?

A natural side effect of adding these features is that our coverage technically increases, because we're adding more covered features to BCD. Before v10.7.0 (specifically, commit 1a08c73), the coverage for css.properties was 213/1227 (17.36%). After v10.7.0 was released (plus a few tweaks, 1adc979), then running add-new-bcd, coverage went down to 206/1784 (11.55%).

Now, if we're focusing only on the coverage improvement of features already tracked in BCD, well, it's only 7 features (a 0.57% difference) -- not exactly a grand improvement. The intention of this change isn't the coverage, but rather improving BCD by adding verbosity about what values we know are supported. If we're just focused on the numbers, then it's a plus for coverage.


Also, what is the plan for avoiding to introduce a lot of ranged values?

I didn't really have a plan for that since we have still been focusing on only correcting errors for browser versions released in 2020 and later. However, it's an easy fix: all we need to do is collect results for older browsers, which is as simple as changing a command line argument.

@Elchi3
Copy link
Member

Elchi3 commented Jan 17, 2024

Thanks for your analysis! I will not review new CSS property values data additions for the moment then. Need to focus on the other goals. I think this would be a great project later in the year, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants