-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get CSS property values from webref #1033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's try.
This is massive. I'm not yet sure we have the bandwidth to review this. Do you know how it will affect our coverage (which is a goal)? Also, what is the plan for avoiding to introduce a lot of ranged values? For example if you have the CSS |
A natural side effect of adding these features is that our coverage technically increases, because we're adding more covered features to BCD. Before v10.7.0 (specifically, commit 1a08c73), the coverage for Now, if we're focusing only on the coverage improvement of features already tracked in BCD, well, it's only 7 features (a 0.57% difference) -- not exactly a grand improvement. The intention of this change isn't the coverage, but rather improving BCD by adding verbosity about what values we know are supported. If we're just focused on the numbers, then it's a plus for coverage.
I didn't really have a plan for that since we have still been focusing on only correcting errors for browser versions released in 2020 and later. However, it's an easy fix: all we need to do is collect results for older browsers, which is as simple as changing a command line argument. |
Thanks for your analysis! I will not review new CSS property values data additions for the moment then. Need to focus on the other goals. I think this would be a great project later in the year, though. |
This PR grabs the values for CSS properties from webref, so that we can stay synchronized with new values introduced in the specification.
Statistics
Before this change, there are 1284 features in
css.properties
. After this change, there are 2510 features. This adds 1,226 new features and removes 0.