Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test code for api.createImageBitmap.svgimageelement_as_source_image #1430

Merged
merged 1 commit into from
May 2, 2024
Merged

Fix test code for api.createImageBitmap.svgimageelement_as_source_image #1430

merged 1 commit into from
May 2, 2024

Conversation

queengooborg
Copy link
Member

This PR fixes #1410.

@queengooborg queengooborg temporarily deployed to mdn-bcd-collector-pr-1430 May 2, 2024 07:57 Inactive
@queengooborg queengooborg merged commit b8e80d8 into main May 2, 2024
5 checks passed
@queengooborg queengooborg deleted the svgimageelement-createimagebitmap branch May 2, 2024 08:00
@Kaiido
Copy link

Kaiido commented May 2, 2024

I don't think this works though. As I explained in #1410 since the SVGImageElement doesn't point to a valid image resource it's actually supposed to throw too, even in browsers that do normally support SVGImageElement as input.

@queengooborg
Copy link
Member Author

Ack, thanks for letting me know -- just wrote a follow-up to load an image!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

api.createImageBitmap.svgimageelement_as_source_image seems broken
2 participants
@queengooborg @Kaiido