Fix JS alternate names #873
Conversation
|
@queengooborg I didn't see fd987b7... I think it doesn't quite work. Would you mind switching to PRs? Otherwise, I'm not really informed about changes that are made to the collector. PRs are actually a nice way to see what is going on. |
| if ( | ||
| featureName === "Atomics" && | ||
| ["WaiterRecord", "WaiterListRecords"].includes(attrName) | ||
| ) { | ||
| // The spec defines WaiterRecord/WaiterListRecords as if they were members of Atomics |
There was a problem hiding this comment.
Why are these lines being removed?
There was a problem hiding this comment.
I logged all attrName that are passed into shouldIgnoreAttr and WaiterRecord/WaiterListRecords are never in there in the first place so I think the check is not needed. Maybe I'm misunderstanding this check?
There was a problem hiding this comment.
It's possible that the spec has since fixed this issue, so we no longer need this ignore in place. I'm not seeing these present in the generated tests now, so I'm going to assume that's the case.
Fix #854