Revert "Simplify replaceAsync function" #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crap...it looks like imports have broken at some point. This is affecting any test that imports the code from another test. When did this break...? |
|
I think it has do to with this unreviewed commit to main: 9adee65 |
Elchi3
changed the title
|
I made this PR to revert the change and I turned on branch protection for main. |
|
Argh...yep, that's the one. How do we not have unittests in place to check if importing tests works...? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the tests here are "Support unknown". Something is wrong with this test.
https://mdn-bcd-collector.gooborg.com/tests/api/HTMLMediaElement
I've changed the instance to create the video element directly and it seems to work better.