Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add namespace support #126

Merged
merged 2 commits into from Feb 10, 2023
Merged

feat: add namespace support #126

merged 2 commits into from Feb 10, 2023

Conversation

XGHeaven
Copy link
Member

@XGHeaven XGHeaven commented Nov 18, 2022 •
edited

RFC: SVG

This PR is the dep of the SVG supports.

Changes:

  • Add createElementNS.
  • Add Element.prototype.namespaceURI.
  • Add Element.prototype.prefix
  • Add Element.prototype.localName
  • Add test for createElementNS.
  • Use prefix and qualified_name to replace tag_name in node.cc

@devjiangzhou devjiangzhou mentioned this pull request Nov 20, 2022
Closed
1 task
@XGHeaven XGHeaven force-pushed the feat/support-namespace branch 2 times, most recently from 2ba70c7 to 82c3f46 Compare November 23, 2022 13:19
@XGHeaven XGHeaven force-pushed the feat/support-namespace branch 2 times, most recently from aad20a7 to dc8b548 Compare February 6, 2023 15:49
@XGHeaven XGHeaven changed the title [WIP]: feat: add namespace support feat: add namespace support Feb 6, 2023
@XGHeaven XGHeaven marked this pull request as ready for review February 6, 2023 15:50
@andycall andycall added this pull request to the merge queue Feb 10, 2023
Merged via the queue into main with commit bd91f3a Feb 10, 2023
@NoahJinnn NoahJinnn mentioned this pull request May 12, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnryb cnryb cnryb left review comments

@andycall andycall andycall approved these changes

@devjiangzhou devjiangzhou devjiangzhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@XGHeaven @devjiangzhou @cnryb @andycall