Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix animation transform: rotate(360deg) #184

Merged
merged 5 commits into from Feb 14, 2023
Merged

fix animation transform: rotate(360deg) #184

merged 5 commits into from Feb 14, 2023

Conversation

suyulin
Copy link
Contributor

@suyulin suyulin commented Dec 7, 2022

fixed animation transform: rotate(360deg) not work.

@keyframes van-rotate {
  from {
    transform: rotate(0deg);
  }

  to {
    transform: rotate(360deg);
  }
}

@andycall
Copy link
Member

andycall commented Dec 16, 2022

Test specs also needed

@suyulin

@suyulin
Copy link
Contributor Author

suyulin commented Jan 7, 2023

Don't know how to write the test,
before:

@keyframes van-rotate {
  from {
    transform: rotate(0deg);
  }

  to {
    transform: rotate(360deg);
  }
}

no animation action
after:
element can spin

@andycall
Copy link
Member

@suyulin done

@suyulin suyulin added this pull request to the merge queue Feb 14, 2023
Merged via the queue into openwebf:main with commit a9dc95a Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants