Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] width/height when naturalWidth unequal real width #25

Closed
wants to merge 4 commits into from

Conversation

yifei8
Copy link
Member

@yifei8 yifei8 commented Aug 15, 2022

fix width/height when naturalWidth unequal real width because of image scale by flutter engine

fix width/height when naturalWidth unequal real width because of image scale by flutter engine
@andycall
Copy link
Member

@yifei8 Integration test are failed, by the way, please add another spec ?

@yifei8
Copy link
Member Author

yifei8 commented Aug 16, 2022

@yifei8 Integration test are failed, by the way, please add another spec ?

This happens on some devices, because the flutter engine compresses the image. The width of the original image is particularly large, which is multiple times the width of the screen. Test cases may not be too good to add.

What is fixed here is a logical problem, the width of the returned image is inconsistent with the size in memory

@andycall
Copy link
Member

But the checks are failed. Can you fixed it?

@yifei8
Copy link
Member Author

yifei8 commented Aug 17, 2022

ok,I will take the time to see how to use these test cases while running locally

@yifei8 yifei8 closed this Aug 26, 2022
@yifei8 yifei8 closed this Sep 5, 2022
@liuzitong123a liuzitong123a mentioned this pull request Oct 21, 2022
1 task
@andycall andycall deleted the yifei8-patch-1 branch June 7, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants