Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Style didn't take effect and offsetLeftToScrollContainer value is calculated incorrectly #322

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Conversation

hzbhzb
Copy link
Contributor

@hzbhzb hzbhzb commented Apr 14, 2023

bugfix:
1、style did not work
demo code

const div = document.createElement('div');
div.appendChild(document.createTextNode('Green Text'));
div.className = "textcolor";
document.body.appendChild(div);
const style = document.createElement('style');
document.head.appendChild(style);
style.appendChild(document.createTextNode(`
        .textcolor {
           color: green;
         }
      `));

2、offsetLeftToScrollContainer error

Copy link
Member

@XGHeaven XGHeaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The commit's author email is different from your GitHub account.
  2. The PR title is also not standard.

Please update them.

@hzbhzb hzbhzb changed the title Fix/update style error fix: Style didn't take effect and offsetLeftToScrollContainer value is calculated incorrectly Apr 18, 2023
@andycall andycall merged commit 86a82f8 into openwebf:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants