Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check ExecutingContext is alive at timer callbacks. #373

Merged
merged 2 commits into from Jun 6, 2023
Merged

fix: check ExecutingContext is alive at timer callbacks. #373

merged 2 commits into from Jun 6, 2023

Conversation

andycall
Copy link
Member

@andycall andycall commented Jun 1, 2023

In some rare user cases, handleTransientCallback and handlePersistentCallback could be fired when the ExecutionContext has already been freed.

@andycall andycall added this pull request to the merge queue Jun 6, 2023
Merged via the queue into main with commit ca54356 Jun 6, 2023
38 checks passed
@andycall andycall deleted the fix/check_timer_callback branch June 6, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@answer-huang answer-huang answer-huang approved these changes

@yifei8 yifei8 yifei8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andycall @answer-huang @yifei8