Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix constructor property on DOM elements. #402

Merged
merged 12 commits into from Jul 11, 2023
Merged

Conversation

andycall
Copy link
Member

@andycall andycall commented Jul 3, 2023

The constructor property on DOM elements should point to the constructor function of DOM elements.

bridge/bindings/qjs/script_wrappable.cc Outdated Show resolved Hide resolved
@yifei8 yifei8 enabled auto-merge July 6, 2023 09:18
@yifei8 yifei8 disabled auto-merge July 6, 2023 09:19
bridge/bindings/qjs/script_wrappable.cc Outdated Show resolved Hide resolved
bridge/core/executing_context_test.cc Outdated Show resolved Hide resolved
@andycall andycall added this pull request to the merge queue Jul 11, 2023
Merged via the queue into main with commit a1962b1 Jul 11, 2023
41 checks passed
@andycall andycall deleted the fix/dom_constructor branch July 11, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants