Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add <circle> <ellipse> element for svg #423

Merged
merged 2 commits into from Jul 20, 2023
Merged

feat: add <circle> <ellipse> element for svg #423

merged 2 commits into from Jul 20, 2023

Conversation

XGHeaven
Copy link
Member

@XGHeaven XGHeaven commented Jul 15, 2023 •
edited

  1. Add <circle> <ellipse> <style> SVG element
  2. Add some tests for that
  3. Add StyleElementMixin used for HTML <style> and SVG <style>
  4. Improve integration test for SVG. Use width/height attribute value as the snapshot image size if that is preset in svg test file. It can reduce the snapshot file size.
  5. Should use width/height as viewbox when height&width is preset and viewBox is omitted.

@yifei8 yifei8 added this pull request to the merge queue Jul 20, 2023
Merged via the queue into main with commit 83d1943 Jul 20, 2023
@yifei8 yifei8 deleted the feat/svg-circle branch July 20, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andycall andycall andycall approved these changes

@yifei8 yifei8 yifei8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@XGHeaven @andycall @yifei8