Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize the evaluate times at the first time. #503

Merged
merged 6 commits into from
Nov 8, 2023

Conversation

andycall
Copy link
Member

This PR eliminates the string encoding process during the evaluateScripts stage, which is unnecessary and can save an average of 15-20% of time when the bundle runs for the first time.

When the same scripts run multiple times, WebF will load the cached bytecode instead of the raw string, so this PR only optimizes the time during the initial run.

@andycall andycall added this pull request to the merge queue Nov 8, 2023
Merged via the queue into main with commit deb675a Nov 8, 2023
28 checks passed
@andycall andycall deleted the feat/optimize_first_eval branch November 8, 2023 03:43
andycall added a commit that referenced this pull request Nov 18, 2023
This PR eliminates the string encoding process during the
evaluateScripts stage, which is unnecessary and can save an average of
15-20% of time when the bundle runs for the first time.

When the same scripts run multiple times, WebF will load the cached
bytecode instead of the raw string, so this PR only optimizes the time
during the initial run.

---------

Co-authored-by: openwebf-bot <openwebf@openwebf.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants