Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix transform value not updated in percentage when box size changed. #514

Merged
merged 3 commits into from Nov 6, 2023

Conversation

andycall
Copy link
Member

@andycall andycall commented Nov 5, 2023

Fix the transform value not updated when self box size changed.

const div = createElement('div', {
      style: {
        position: 'absolute',
        padding: '10px 20px',
        border: '1px solid #000',
        left: '50%',
        transform: 'translate(-50%)'
      }
    }, [
      createText('ABC')
    ]);
    document.body.appendChild(div);
    await snapshot()

    div.textContent = 'LONGER TEXT LONGER TEXT';
    await snapshot();

@andycall andycall added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit 80bbada Nov 6, 2023
1 check passed
@andycall andycall deleted the fix/update_percentage_transform branch November 6, 2023 10:16
andycall added a commit that referenced this pull request Nov 18, 2023
…ged. (#514)

Fix the transform value not updated when self box size changed.

```
const div = createElement('div', {
      style: {
        position: 'absolute',
        padding: '10px 20px',
        border: '1px solid #000',
        left: '50%',
        transform: 'translate(-50%)'
      }
    }, [
      createText('ABC')
    ]);
    document.body.appendChild(div);
    await snapshot()

    div.textContent = 'LONGER TEXT LONGER TEXT';
    await snapshot();
```

---------

Co-authored-by: openwebf-bot <openwebf@openwebf.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants