Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix init touchEvent from JS cause crash. #518

Merged
merged 2 commits into from Nov 7, 2023
Merged

Conversation

andycall
Copy link
Member

@andycall andycall commented Nov 7, 2023

The following JavaScript code is causing crashes:

image

 const container = createElement('div', {}, []);
document.body.appendChild(container);
const touchEvent = new TouchEvent('touchstart');
container.dispatchEvent(touchEvent);

const touchEvent2 = new TouchEvent('touchstart', {});
container.dispatchEvent(touchEvent2);

@andycall andycall added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit 8bbe7f6 Nov 7, 2023
25 checks passed
@andycall andycall deleted the fix/init_touch_crash branch November 7, 2023 11:41
andycall added a commit that referenced this pull request Nov 18, 2023
The following JavaScript code is causing crashes:


![image](https://github.com/openwebf/webf/assets/4409743/f3ccc0ef-4a42-4eaf-872d-11bc25abbfaf)


```javascript
 const container = createElement('div', {}, []);
document.body.appendChild(container);
const touchEvent = new TouchEvent('touchstart');
container.dispatchEvent(touchEvent);

const touchEvent2 = new TouchEvent('touchstart', {});
container.dispatchEvent(touchEvent2);
```

---------

Co-authored-by: openwebf-bot <openwebf@openwebf.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants