feat: optimize bytecode cache load speed and fix http cache #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomesVWhite
reviewed
Jan 29, 2024
andycall
force-pushed
the
feat/optimize_js_cache_load
branch
from
b05d60e
to
6f4a34c
Compare
answer-huang
approved these changes
Feb 3, 2024
TomesVWhite
approved these changes
Feb 20, 2024
andycall
force-pushed
the
feat/optimize_js_cache_load
branch
from
a335261
to
8d8d0da
Compare
andycall
force-pushed
the
feat/optimize_js_cache_load
branch
from
23becb9
to
bf3fc86
Compare
answer-huang
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP cache relies on the contextId to function. However, this PR introduced a bug that make the entire HTTP cache mode ineffective.
According to profile data, we found that the
getCrc32(bytes.toList())takes lots of time with unexpected and can be optimized withgetCrc32(bytes)instead.The
CookieJar.setCookieStringalso take lots of times unexpected and can be optimized by making the file write async.