Add the a variants of the arc trig functions.
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes openwebwork/webwork2#2209. This is built on top of openwebwork#27 (so that dist includes a build that won't confict).
So now the trig functions include `sin`, `arcsin`, `asin`, `sinh`, `arcsinh`, and `asinh`. However, when `asin` is typed, it automatically is turned into `arcsin`. Of course all of the `a` variants for `cos`, `tan`, `sec`, `csc`, and `cot` are added with the same behavior.
drgrice1
added a commit
to drgrice1/pg
that referenced
this pull request
Apr 27, 2024
drgrice1
added a commit
to drgrice1/pg
that referenced
this pull request
May 17, 2024
drgrice1
added a commit
to drgrice1/pg
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So now the trig functions include
sin,arcsin,asin,sinh,arcsinh, andasinh.However, when
asinis typed, it automatically is turned intoarcsin.Of course all of the
avariants forcos,tan,sec,csc, andcotare added with the same behavior.The space before trig functions (if preceded by a letter) in text output added in #28 is still needed. One could type
sin, and then go back and addabefore it, and it will not be turned intoasinorarcsin, and so PG would still interpret that asasinin that case without the space.Note that the
avariants will need to be added to the auto commands of themqeditor.jsfile in order for this to work for PG.