Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error answers now are escaped when they shouldn't be. #1021

Closed
drgrice1 opened this issue Feb 20, 2024 · 1 comment
Closed

Error answers now are escaped when they shouldn't be. #1021

drgrice1 opened this issue Feb 20, 2024 · 1 comment

Comments

@drgrice1
Copy link
Sponsor Member

drgrice1 commented Feb 20, 2024

#1004 didn't solve the issue with student answers not being escaped in the right way. Now answers are being escaped that shouldn't be.

Use the problem posted in #990 (comment), and enter an answer like r<1,-4,3,0>+s<2,2,1,8>. If that is correct, then change the numbers so it is not. The html in the answer is now protected by the change in #1004, and so you see things like &lt; instead of <.

Now, change the line in the problem that has Context("Matrix")->flags->set(requireConstantEntries => 1); to Context("Matrix")->flags->set(requireConstantVectors => 1); (since that is what the flag was later changed to in #990). Then enter <r,-4r,3r,0>+s<2,2,18> where that is actually the correct answer for your seed, but with r in the entries of the first vector. Of course this shows up correctly.

Now if you revert #1004, then the first example is displayed correctly, but the second is not.

@drgrice1
Copy link
Sponsor Member Author

drgrice1 commented Apr 7, 2024

I believe this was fixed with #1027.

@drgrice1 drgrice1 closed this as completed Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant