Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewing all correct answers at the same time #1047

Closed
Alex-Jordan opened this issue Mar 31, 2024 · 4 comments
Closed

Viewing all correct answers at the same time #1047

Alex-Jordan opened this issue Mar 31, 2024 · 4 comments

Comments

@Alex-Jordan
Copy link
Contributor

With the new feedback button tool, it is difficult/impossible to see multiple/all of the expected correct answers at the same time, which you could do with the old results table. There are times when it is reasonable to want to do that, like with Library/Valdosta/APEX_Calculus/4.1/APEX_4.1_4.pg.

I'm not sure what to do about this, but I can describe what PTX does. There is another button to reveal correct answers, and when you push it, all answer input fields get filled in with the expected correct answer. Of course it's not as simple as that, because there are regular inputs, MathQuill inputs, and non-textual inputs like radio buttons, checkboxes, and select elements.

@drgrice1
Copy link
Sponsor Member

We discussed adding a list of correct answers after the problem at our last meeting. However, as I mentioned in openwebwork/webwork2#2395, I don't think that this will look very nice. In addition, there will be implementation challenges (particularly for graph tool problems).

So, how about instead of adding a list of correct answers after the problem (or at the bottom of the problem), add a "Show Correct Answers" button below the other buttons, and when that button is clicked do a different kind of feedback popover. Basically, instead of showing all of the feedback information with a title on the popover, only have the correct answer in the popover with no popover title (and a close button to the right), and instead of having the popover below the feedback button, have it to the right (with a fallback placement below or maybe to the left?). Furthermore, make the popovers open immediately when the page opens. To avoid problems with scaffolds those would all be forced to be open for this.

I was thinking that this could even be available for students after the answer date.

Here are some mock up screen shots of what this would look like:

basic
scaffold

I implemented this enough to make the mock ups, but it is all forced, so not really implemented. If this sounds like a good idea, then I will work on properly implement it. It will take changes to both webwork2 and pg, and probably a new translation option for feedback.

There are probably some other details that will need to be figured out, but this seems like a nicer way of doing this than a list below, and since there will always be one form of the correct answer for each answer on the page at a time, it avoids an implementation issue for graph tool problems.

@Alex-Jordan
Copy link
Contributor Author

This sounds good. What matters most is the the issue of seeing multiple answers at the same time, and I don't have a preference for any particular method to make that happen. Your points about the cons of other ways are good points.

In your mockups, there are filled-in answers in the input fields and green checkmarks. Would it always look like that? I'm guessing not, but wanted to check.

  • What would it look like if an input field was empty and someone pushed the new button?
  • What would it look like if an input field was filled in (incorrect, correct, correct but not the canonical answer, partially correct) and someone pushed the new button?

@drgrice1
Copy link
Sponsor Member

Yeah, I just left the button the way it was in the mock up. I am not sure what it should be. Should it still grade, and have the correct, incorrect, partially correct colors and icons, or should it just use the preview color and icon, or something else?

@Alex-Jordan
Copy link
Contributor Author

The user had that one specific objective, to see the expected correct answers. So maybe to reduce clutter it would be best to not show the usual feedback buttons.

I guess the question is, does a user ever need to see all the expected correct answers at the same time as seeing assessments made on their own attempts? Or is it good enough to have the existing feedback buttons, plus this way of showing all correct answers at once?

drgrice1 added a commit to drgrice1/webwork2 that referenced this issue Apr 20, 2024
When this button is used correct answers will be shown with no other
content in the feedback popover, scaffolds will all be open, and the
feedback popovers will open immediately on page load. This is an
instructor only option for now.  I don't think this will be a good idea
to enable for students.

Furthermore, the "Show Correct Answers" buttons on other instructor
pages (pg problem editor, problem library, set detail page, statistics,
and manual problem grader) now use this for showing correct answers.

This works well for most problems, but there are some cases where
answers are tightly grouped particularly when there are on the same line
that the popovers can overlap in not the best way.

This is one potential resolution of openwebwork/pg#1047.
drgrice1 added a commit to drgrice1/webwork2 that referenced this issue Apr 21, 2024
When this button is used correct answers will be shown with no other
content in the feedback popover, scaffolds will all be open, and the
feedback popovers will open immediately on page load. This is an
instructor only option for now.  I don't think this will be a good idea
to enable for students.

Furthermore, the "Show Correct Answers" buttons on other instructor
pages (pg problem editor, problem library, set detail page, statistics,
and manual problem grader) now use this for showing correct answers.

This works well for most problems, but there are some cases where
answers are tightly grouped particularly when there are on the same line
that the popovers can overlap in not the best way.

This is one potential resolution of openwebwork/pg#1047.
drgrice1 added a commit to drgrice1/webwork2 that referenced this issue Apr 23, 2024
When this button is used correct answers will be shown with no other
content in the feedback popover, scaffolds will all be open, and the
feedback popovers will open immediately on page load. This is an
instructor only option for now.  I don't think this will be a good idea
to enable for students.

Furthermore, the "Show Correct Answers" buttons on other instructor
pages (pg problem editor, problem library, set detail page, statistics,
and manual problem grader) now use this for showing correct answers.

This works well for most problems, but there are some cases where
answers are tightly grouped particularly when there are on the same line
that the popovers can overlap in not the best way.

This is one potential resolution of openwebwork/pg#1047.
drgrice1 added a commit to drgrice1/webwork2 that referenced this issue Apr 26, 2024
When this button is used correct answers will be shown with no other
content in the feedback popover, scaffolds will all be open, and the
feedback popovers will open immediately on page load. This is an
instructor only option for now.  I don't think this will be a good idea
to enable for students.

Furthermore, the "Show Correct Answers" buttons on other instructor
pages (pg problem editor, problem library, set detail page, statistics,
and manual problem grader) now use this for showing correct answers.

This works well for most problems, but there are some cases where
answers are tightly grouped particularly when there are on the same line
that the popovers can overlap in not the best way.

This is one potential resolution of openwebwork/pg#1047.
drgrice1 added a commit to drgrice1/webwork2 that referenced this issue Apr 30, 2024
When this button is used correct answers will be shown with no other
content in the feedback popover, scaffolds will all be open, and the
feedback popovers will open immediately on page load. This is an
instructor only option for now.  I don't think this will be a good idea
to enable for students.

Furthermore, the "Show Correct Answers" buttons on other instructor
pages (pg problem editor, problem library, set detail page, statistics,
and manual problem grader) now use this for showing correct answers.

This works well for most problems, but there are some cases where
answers are tightly grouped particularly when there are on the same line
that the popovers can overlap in not the best way.

This is one potential resolution of openwebwork/pg#1047.
drgrice1 added a commit to drgrice1/webwork2 that referenced this issue May 8, 2024
When this button is used correct answers will be shown with no other
content in the feedback popover, scaffolds will all be open, and the
feedback popovers will open immediately on page load. This is an
instructor only option for now.  I don't think this will be a good idea
to enable for students.

Furthermore, the "Show Correct Answers" buttons on other instructor
pages (pg problem editor, problem library, set detail page, statistics,
and manual problem grader) now use this for showing correct answers.

This works well for most problems, but there are some cases where
answers are tightly grouped particularly when there are on the same line
that the popovers can overlap in not the best way.

This is one potential resolution of openwebwork/pg#1047.
drgrice1 added a commit to drgrice1/webwork2 that referenced this issue May 17, 2024
When this button is used correct answers will be shown with no other
content in the feedback popover, scaffolds will all be open, and the
feedback popovers will open immediately on page load. This is an
instructor only option for now.  I don't think this will be a good idea
to enable for students.

Furthermore, the "Show Correct Answers" buttons on other instructor
pages (pg problem editor, problem library, set detail page, statistics,
and manual problem grader) now use this for showing correct answers.

This works well for most problems, but there are some cases where
answers are tightly grouped particularly when there are on the same line
that the popovers can overlap in not the best way.

This is one potential resolution of openwebwork/pg#1047.
drgrice1 added a commit to openwebwork/webwork2 that referenced this issue May 31, 2024
When this button is used correct answers will be shown with no other
content in the feedback popover, scaffolds will all be open, and the
feedback popovers will open immediately on page load. This is an
instructor only option for now.  I don't think this will be a good idea
to enable for students.

Furthermore, the "Show Correct Answers" buttons on other instructor
pages (pg problem editor, problem library, set detail page, statistics,
and manual problem grader) now use this for showing correct answers.

This works well for most problems, but there are some cases where
answers are tightly grouped particularly when there are on the same line
that the popovers can overlap in not the best way.

This is one potential resolution of openwebwork/pg#1047.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants